Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: allow tests to opt out of dead node validation #102131

Closed
smg260 opened this issue Apr 24, 2023 · 1 comment · Fixed by #102162
Closed

roachtest: allow tests to opt out of dead node validation #102131

smg260 opened this issue Apr 24, 2023 · 1 comment · Fixed by #102162
Assignees
Labels
A-testing Testing tools and infrastructure C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-testeng TestEng Team

Comments

@smg260
Copy link
Contributor

smg260 commented Apr 24, 2023

#101254 fixed a long standing bug regarding a post test validation to ensure that there are no dead nodes (previously not working at all)

However, there are tests that expects dead (or stopped) nodes, which now fail.

We need a feature to opt out of dead node validation.

All failed tests due to dead node validation:
image

Jira issue: CRDB-27298

Affected failures:

#102135
#102053
#102054
#102057
#102061
#102062

@smg260 smg260 added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-testing Testing tools and infrastructure T-testeng TestEng Team labels Apr 24, 2023
@smg260 smg260 self-assigned this Apr 24, 2023
@blathers-crl
Copy link

blathers-crl bot commented Apr 24, 2023

cc @cockroachdb/test-eng

smg260 pushed a commit to smg260/cockroach that referenced this issue Apr 24, 2023
…when

dead nodes are detected.

Epic: none
Fixes: cockroachdb#102131

Release note: None
craig bot pushed a commit that referenced this issue Apr 24, 2023
102162: roachtest: Allow roachtests to opt out of failing in post validation … r=srosenberg a=smg260

…when

dead nodes are detected.

Skips dead node assertion failures in all roachtests in #102131.

Also, the change explicitly checks for a message starting with "dead" to avoid failing on a flake during teardown.

Epic: none
Fixes: #102131

Release note: None

Co-authored-by: Miral Gadani <[email protected]>
@craig craig bot closed this as completed in bfbc704 Apr 24, 2023
smg260 pushed a commit to smg260/cockroach that referenced this issue Jun 15, 2023
…when

dead nodes are detected.

Epic: none
Fixes: cockroachdb#102131

Release note: None
Release justification: test only changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testing Testing tools and infrastructure C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-testeng TestEng Team
Projects
None yet
1 participant