Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: we should add UDFs to statement bundles #102044

Closed
rytaft opened this issue Apr 21, 2023 · 0 comments · Fixed by #102860
Closed

sql: we should add UDFs to statement bundles #102044

rytaft opened this issue Apr 21, 2023 · 0 comments · Fixed by #102860
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) E-quick-win Likely to be a quick win for someone experienced. O-qa T-sql-queries SQL Queries Team

Comments

@rytaft
Copy link
Collaborator

rytaft commented Apr 21, 2023 •
edited by cockroach-jira-scripts
Loading

Is your feature request related to a problem? Please describe.

Currently, any UDFs used by a query are not included in the statement bundle. This will make it impossible to reproduce the issue.

Describe the solution you'd like

We should add the definitions of any UDFs used by the query to the schema.sql file.

Jira issue: CRDB-27237
@rytaft rytaft added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) O-qa labels Apr 21, 2023
@blathers-crl blathers-crl bot added the T-sql-queries SQL Queries Team label Apr 21, 2023
@rharding6373 rharding6373 added the E-quick-win Likely to be a quick win for someone experienced. label May 2, 2023
lyang24 pushed a commit to lyang24/cockroach that referenced this issue May 7, 2023
Statement bundles now include the CREATE statements for relevant udfs…
1830602 
… in schema.sql.

Epic: None
Fixes: cockroachdb#102044

Release note: None
@lyang24 lyang24 mentioned this issue May 7, 2023
Merged
lyang24 pushed a commit to lyang24/cockroach that referenced this issue May 15, 2023
Statement bundles now include the CREATE statements for relevant udfs…
053b6cb 
… in schema.sql.

Epic: None
Fixes: cockroachdb#102044

Release note: None
lyang24 pushed a commit to lyang24/cockroach that referenced this issue May 15, 2023
Statement bundles now include the CREATE statements for relevant udfs…
1588053 
… in schema.sql.

Epic: None
Fixes: cockroachdb#102044

Release note: None
lyang24 pushed a commit to lyang24/cockroach that referenced this issue May 15, 2023
Statement bundles now include the CREATE statements for relevant udfs…
ad24e04 
… in schema.sql.

Epic: None
Fixes: cockroachdb#102044

Release note: None
lyang24 pushed a commit to lyang24/cockroach that referenced this issue May 15, 2023
Statement bundles now include the CREATE statements for relevant udfs…
fb6ff9e 
… in schema.sql.

Epic: None
Fixes: cockroachdb#102044

Release note: None
craig bot pushed a commit that referenced this issue May 16, 2023
Merge #102860
ced1347 
102860: sql: add relevant udfs to statement bundles r=rytaft,michae2 a=lyang24

Statement bundles now include the CREATE statements for relevant udf in schema.sql.

Epic: None
Fixes: #102044

Release note: None

Co-authored-by: Eric.Yang <[email protected]>
@craig craig bot closed this as completed in dea1354 May 16, 2023
@rytaft rytaft mentioned this issue May 16, 2023
Merged
rytaft pushed a commit to rytaft/cockroach that referenced this issue May 16, 2023
@rytaft
Statement bundles now include the CREATE statements for related udfs …
b6d81db 
…in schema.sql.

Epic: None
Fixes: cockroachdb#102044

Release note: None
@mgartner mgartner moved this to Done in SQL Queries Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) E-quick-win Likely to be a quick win for someone experienced. O-qa T-sql-queries SQL Queries Team
Projects
SQL Queries
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sql: add relevant udfs to statement bundles lyang24/cockroach
2 participants
@rytaft @rharding6373