-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
: TestStoreRangeRebalance failed under stress #10156
Comments
Fails instantly: |
Another failure mode: This is on #10327, I wasn't able to repro this on Sure seems like we should look into this test more proactively. I might try after I get my PR merged.
|
Nevermind, on
@tamird I think you mentioned said error to me recently. |
Another failure mode (seen in exp-prop-kv without exp-prop-kv enabled):
|
And a data race, this time from a CI run on proposer-evaluated KV. Wasn't able to repro this either where it happened nor on master. The offending line is if pErr != nil {
pErr.Now = now // <--
} else { The race happens right after the "new range lease" message and before a pErr := make_error()
client1Chan <- pErr
client2Chan <- pErr
|
Rather than the somewhat complicated rebalancing scenario, use a simple scenario that we perform up-replication of range 1 from 1 to 3 nodes. We check that this up-replication is performed using preemptive snapshots. The more complicated scenario was very fragile, frequently being broken by innocuous changes. Fixes cockroachdb#10497 Fixes cockroachdb#10193 Fixes cockroachdb#10156 Fixes cockroachdb#9395
Rather than the somewhat complicated rebalancing scenario, use a simple scenario that we perform up-replication of range 1 from 1 to 3 nodes. We check that this up-replication is performed using preemptive snapshots. The more complicated scenario was very fragile, frequently being broken by innocuous changes. Fixes cockroachdb#10497 Fixes cockroachdb#10193 Fixes cockroachdb#10156 Fixes cockroachdb#9395
Rather than the somewhat complicated rebalancing scenario, use a simple scenario that we perform up-replication of range 1 from 1 to 3 nodes. We check that this up-replication is performed using preemptive snapshots. The more complicated scenario was very fragile, frequently being broken by innocuous changes. Fixes cockroachdb#10193 Fixes cockroachdb#10156 Fixes cockroachdb#9395
Add the check that preemptive snapshots are being used to TestStoreRangeUpReplicate. Add TestReplicateQueueRebalance for testing that basic rebalancing is working. Fixes cockroachdb#10193 Fixes cockroachdb#10156 Fixes cockroachdb#9395
Add the check that preemptive snapshots are being used to TestStoreRangeUpReplicate. Add TestReplicateQueueRebalance for testing that basic rebalancing is working. Fixes cockroachdb#10193 Fixes cockroachdb#10156 Fixes cockroachdb#9395
Add the check that preemptive snapshots are being used to TestStoreRangeUpReplicate. Add TestReplicateQueueRebalance for testing that basic rebalancing is working. Fixes cockroachdb#10193 Fixes cockroachdb#10156 Fixes cockroachdb#9395
Add the check that preemptive snapshots are being used to TestStoreRangeUpReplicate. Add TestReplicateQueueRebalance for testing that basic rebalancing is working. Fixes cockroachdb#10193 Fixes cockroachdb#10156 Fixes cockroachdb#9395
Add the check that preemptive snapshots are being used to TestStoreRangeUpReplicate. Add TestReplicateQueueRebalance for testing that basic rebalancing is working. Fixes cockroachdb#10193 Fixes cockroachdb#10156 Fixes cockroachdb#9395
SHA: https://github.com/cockroachdb/cockroach/commits/7071c024c8695bd9963af293e311626ebc675961
Stress build found a failed test:
The text was updated successfully, but these errors were encountered: