Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL Activity fail to load on mixed version 22.2 - 23.1 state #100501

Closed
maryliag opened this issue Apr 3, 2023 · 0 comments · Fixed by #100703
Closed

SQL Activity fail to load on mixed version 22.2 - 23.1 state #100501

maryliag opened this issue Apr 3, 2023 · 0 comments · Fixed by #100703
Assignees
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.

Comments

@maryliag
Copy link
Contributor

maryliag commented Apr 3, 2023

SQL Activity page fail to load on mixed version state

Jira issue: CRDB-26467

@maryliag maryliag added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-cluster-observability labels Apr 3, 2023
@maryliag maryliag self-assigned this Apr 4, 2023
maryliag added a commit to maryliag/cockroach that referenced this issue Apr 4, 2023
Fixes cockroachdb#100501

Adds `{statement|transaction}_statistics_persisted_v22_2`
like they were added on cockroachdb#96454.
Check the version of the cluster before deciding which view
to use.
This is required for mixed version cluster with 22.2 and 23.1 versions.

Release note: None
state between 22.2 and 23.1
maryliag added a commit to maryliag/cockroach that referenced this issue Apr 5, 2023
Fixes cockroachdb#100501

Adds `{statement|transaction}_statistics_persisted_v22_2`
like they were added on cockroachdb#96454.
Check the version of the cluster before deciding which view
to use.
This is required for mixed version cluster with 22.2 and 23.1 versions.

Release note: None
maryliag added a commit to maryliag/cockroach that referenced this issue Apr 5, 2023
Fixes cockroachdb#100501

Adds `{statement|transaction}_statistics_persisted_v22_2`
like they were added on cockroachdb#96454.
Check the version of the cluster before deciding which view
to use.
This is required for mixed version cluster with 22.2 and 23.1 versions.

Release note: None
maryliag added a commit to maryliag/cockroach that referenced this issue Apr 5, 2023
Fixes cockroachdb#100501

Adds {statement|transaction}_statistics_persisted_v22_2 like they were added on cockroachdb#96454.
Check the version of the cluster before deciding which view to use.
This is required for mixed version cluster with 22.2 and 23.1 versions.

Release note: None
craig bot pushed a commit that referenced this issue Apr 10, 2023
100618: builtins: remove WaitPolicy error from fingerprinting builtin r=dt a=adityamaru

During development the wait policy for ExportRequests sent during fingerprinting was set to error. This meant that if the ExportRequest encountered an intent it would immediately return and error out. This is fine if we added a retry loop similar to how backup processor requeues the request to be sent at a later time by when the intent is resolved, but as is this is incorrect. We change the WaitPolicy to block so that the ExportRequest blocks until the intent is resolved. If in the future we want to make progress while another ExportRequest is stuck resolving intents we can rework this logic to look similar to our backup strategy.

Release note: None
Epic: none

100703: sql: add new persistedV22_2 views r=maryliag a=maryliag

Note to reviewers: this is a forward-porting from #100673

Fixes #100501

Adds {statement|transaction}_statistics_persisted_v22_2 like they were added on #96454. Check the version of the cluster before deciding which view to use. This is required for mixed version cluster with 22.2 and 23.1 versions.

Release note: None

100734: backupccl: gate writing slim manifests in backup via cluster setting r=rhu713 a=rhu713

Feature gate the writing of slim manifests at the end of backup jobs with
the cluster setting `backup.write_metadata_with_external_ssts.enabled`.

Release note: None

100916: roachtest: fix c2c/shutdown/dest bug r=dt,adityamaru a=msbutler

Previously, the c2c/shutdown/dest tests were incorrectly shutting down nodes on the source cluster. This patch fixes this.

Fixes #100907

Release note: None

101057: sqlproxyccl: skip TestDirectoryConnect r=adityamaru a=knz

Informs #76839.

Release note: None
Epic: None

Co-authored-by: adityamaru <[email protected]>
Co-authored-by: maryliag <[email protected]>
Co-authored-by: Rui Hu <[email protected]>
Co-authored-by: Michael Butler <[email protected]>
Co-authored-by: Raphael 'kena' Poss <[email protected]>
@craig craig bot closed this as completed in 3dabaaf Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Projects
None yet
1 participant