Skip to content

Commit

Permalink
ui: fix default value of filter to All
Browse files Browse the repository at this point in the history
A recent commit changed the default value of filter
to be an empty string, but we do have transactions that have
no associated app names to it, so All and empty string
should be treated as different cases. This commit reverse
that changes and use All

Release note (bug fix): Show All statements when filter All is
selected and not only the ones with empty string
  • Loading branch information
maryliag committed Oct 14, 2021
1 parent 44226ec commit fd09940
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions pkg/ui/workspaces/cluster-ui/src/queryFilter/filter.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ const timeUnit = [
];

export const defaultFilters: Filters = {
app: "",
app: "All",
timeNumber: "0",
timeUnit: "seconds",
fullScan: false,
Expand Down Expand Up @@ -116,7 +116,7 @@ export const getFiltersFromQueryString = (
* we want to consider 0 active Filters
*/
export const inactiveFiltersState: Filters = {
app: "",
app: "All",
timeNumber: "0",
fullScan: false,
sqlType: "",
Expand Down

0 comments on commit fd09940

Please sign in to comment.