metrics: refactor histogram bucket generation and testing

This commit refactors histogram bucketing for legibility and composibility. It also introduces a data-driven test for histogram bucket generation. This refactor should make it easier to add additional metric categories, distributions, and bucket types. Part of #97144. Release note: None
cockroachdb · Jul 24, 2023 · f920b0c · f920b0c
1 parent cdf12cf
commit f920b0c
Show file tree

Hide file tree

Showing 12 changed files with 424 additions and 381 deletions.
diff --git a/pkg/util/metric/BUILD.bazel b/pkg/util/metric/BUILD.bazel
@@ -59,7 +59,6 @@ go_test(
         "//pkg/testutils/datapathutils",
         "//pkg/testutils/echotest",
         "//pkg/util/log",
-        "@com_github_dustin_go_humanize//:go-humanize",
         "@com_github_kr_pretty//:pretty",
         "@com_github_prometheus_client_golang//prometheus",
         "@com_github_prometheus_client_model//go",