Skip to content

Commit

Permalink
kvserver: don't log "local QPS is below max threshold" by default
Browse files Browse the repository at this point in the history
This log message is the 9th most voluminous across the CC fleet.
It's not surprising since most stores are idle.
There's no good reason to have it logged by default - it doesn't say
anything interesting.
Let's just keep it in traces.

Release note: None
  • Loading branch information
knz committed Sep 30, 2022
1 parent a87b3d0 commit f728c1e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/kv/kvserver/store_rebalancer.go
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,7 @@ func (sr *StoreRebalancer) rebalanceStore(
// cluster-level overfull threshold of QPS.
qpsMaxThreshold := overfullQPSThreshold(options, allStoresList.candidateQueriesPerSecond.mean)
if !(localDesc.Capacity.QueriesPerSecond > qpsMaxThreshold) {
log.Infof(ctx, "local QPS %.2f is below max threshold %.2f (mean=%.2f); no rebalancing needed",
log.VEventf(ctx, 1, "local QPS %.2f is below max threshold %.2f (mean=%.2f); no rebalancing needed",
localDesc.Capacity.QueriesPerSecond, qpsMaxThreshold, allStoresList.candidateQueriesPerSecond.mean)
return
}
Expand Down

0 comments on commit f728c1e

Please sign in to comment.