Merge #107618 #107927

107618: engineccl: add randomized error injector test for encryptedFS r=jbowens a=sumeerbhola The encryptedFS can return an error after doing part of the work, as modifying the encryption metadata and the underlying FS is not atomic. This makes some operations (rename, link, remove) non-idempotent, which is harmless for the CockroachDB use cases (since they don't retry on the same files). The test works around these by retrying in a way that makes them idempotent. Additionally, the test catches panics caused by FS errors, in order to test a node that crashes because of a panic caused by a transient error, and is subsequently restarted. Epic: none Informs: #96670 Release note: None 107927: roachtest: ignore some ORM tests r=rafiss a=rafiss fixes #107698 fixes #107849 fixes #107861 fixes #107869 Release note: None Co-authored-by: sumeerbhola <[email protected]> Co-authored-by: Rafi Shamim <[email protected]>
cockroachdb · Aug 1, 2023 · f6c4d9d · f6c4d9d
3 parents da59f58 + fde64cc + 9061bd6
commit f6c4d9d
Show file tree

Hide file tree

Showing 7 changed files with 496 additions and 3 deletions.
diff --git a/pkg/ccl/storageccl/engineccl/BUILD.bazel b/pkg/ccl/storageccl/engineccl/BUILD.bazel
@@ -61,9 +61,12 @@ go_test(
         "//pkg/util/randutil",
         "//pkg/util/timeutil",
         "@com_github_cockroachdb_datadriven//:datadriven",
+        "@com_github_cockroachdb_errors//:errors",
+        "@com_github_cockroachdb_errors//oserror",
         "@com_github_cockroachdb_pebble//:pebble",
         "@com_github_cockroachdb_pebble//vfs",
         "@com_github_cockroachdb_pebble//vfs/atomicfs",
+        "@com_github_cockroachdb_pebble//vfs/errorfs",
         "@com_github_gogo_protobuf//proto",
         "@com_github_kr_pretty//:pretty",
         "@com_github_stretchr_testify//require",