Skip to content

Commit

Permalink
backupccl: skip timing based regression test under deadlock
Browse files Browse the repository at this point in the history
TestCleanupIntentsDuringBackupPerformanceRegression ensures that
intent resolution does not take >20s when running in a controlled
environment. We have seen instances of this test when run under deadlock
taking 22-24s causing the test to fail. Given that this test is very
sensitive to timing, it does not make sense to run it under deadlock.

Fixes: #100034
Release note: None
  • Loading branch information
adityamaru committed Jun 27, 2023
1 parent b0ef999 commit f3ee29d
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion pkg/ccl/backupccl/backup_intents_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@ func TestCleanupIntentsDuringBackupPerformanceRegression(t *testing.T) {
defer log.Scope(t).Close(t)
defer ccl.TestingEnableEnterprise()()

skip.UnderRace(t, "measures backup times not to regress, can't work under race")
skip.UnderRace(t, "measures backup times to ensure intent resolution does not regress, can't work under race")
skip.UnderDeadlock(t, "measures backup times to ensure intent resolution does not regress, can't work under deadlock")

// Time to create backup in presence of intents differs roughly 10x so some
// arbitrary number is picked which is 2x higher than current backup time on
Expand Down

0 comments on commit f3ee29d

Please sign in to comment.