Skip to content

Commit

Permalink
roachpb: remove system span config protos
Browse files Browse the repository at this point in the history
We'll instead use roachpb.SpanConfig to represent system span configs
as well; in the future, we'll just wrap it in a go type an do some
validation.

Release note: None
  • Loading branch information
arulajmani committed Feb 9, 2022
1 parent 799eee3 commit f38d556
Showing 1 changed file with 0 additions and 33 deletions.
33 changes: 0 additions & 33 deletions pkg/roachpb/span_config.proto
Original file line number Diff line number Diff line change
Expand Up @@ -175,39 +175,6 @@ message SpanConfigEntry {
SpanConfig config = 2 [(gogoproto.nullable) = false];
};

// SystemSpanConfig is a system installed configuration that may apply to
// multiple spans.
message SystemSpanConfig {
option (gogoproto.equal) = true;

// ProtectionPolicies is a list of policies which protect data from being
// GC-ed.
repeated ProtectionPolicy protection_policies = 1 [(gogoproto.nullable) = false];
}

// SystemSpanConfigTarget is used to specify the target of a SystemSpanConfig.
message SystemSpanConfigTarget {
// TenantID indicates the tenant ID of the logical cluster being targeted.
// For secondary tenants this field is left unset. For the host we can use
// this field to protect a specific secondary tenant.
//
// TODO(arul): Ensure that secondary tenants don't populate this field when
// we make use of these in the RPC.
roachpb.TenantID tenant_id = 1 [(gogoproto.customname) = "TenantID", (gogoproto.nullable) = true];
}


// SystemSpanConfigEntry is a SystemSpanConfigTarget and its corresponding
// SystemSpanConfig.
message SystemSpanConfigEntry {
// SystemSpanConfigTarget represents the target over which the config is said
// to apply.
SystemSpanConfigTarget system_span_config_target = 1 [(gogoproto.nullable) = false];

// SystemSpanConfig is the config that applies.
SystemSpanConfig system_span_config = 2 [(gogoproto.nullable) = false];
}

// GetSpanConfigsRequest is used to fetch the span configurations over the
// specified keyspans.
message GetSpanConfigsRequest {
Expand Down

0 comments on commit f38d556

Please sign in to comment.