Skip to content

Commit

Permalink
Merge #32904
Browse files Browse the repository at this point in the history
32904: roachtest: add an initial rangefeed+cdc test for iteration r=mrtracy a=danhhz

There are a number of open work items for closed timestamps and
rangefeed. Merging this now before it all works reliably to help with
prioritization.

Release note: None

Co-authored-by: Daniel Harrison <[email protected]>
  • Loading branch information
craig[bot] and danhhz committed Dec 6, 2018
2 parents 5c1ffd1 + b98d136 commit f0ac764
Showing 1 changed file with 24 additions and 0 deletions.
24 changes: 24 additions & 0 deletions pkg/cmd/roachtest/cdc.go
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ type cdcTestArgs struct {
tpccWarehouseCount int
workloadDuration string
initialScan bool
rangefeed bool
kafkaChaos bool
crdbChaos bool

Expand All @@ -68,6 +69,11 @@ func cdcBasicTest(ctx context.Context, t *test, c *cluster, args cdcTestArgs) {

db := c.Conn(ctx, 1)
defer stopFeeds(db)
if _, err := db.Exec(
`SET CLUSTER SETTING kv.rangefeed.enabled = $1`, args.rangefeed,
); err != nil {
t.Fatal(err)
}

t.Status("installing kafka")
kafka := kafkaManager{
Expand Down Expand Up @@ -343,6 +349,24 @@ func registerCDC(r *registry) {
})
},
})
r.Add(testSpec{
Name: "cdc/rangefeed-unstable",
Skip: `resolved timestamps are not yet reliable with RangeFeed`,
MinVersion: "2.2.0",
Nodes: nodes(4, cpu(16)),
Run: func(ctx context.Context, t *test, c *cluster) {
cdcBasicTest(ctx, t, c, cdcTestArgs{
workloadType: tpccWorkloadType,
tpccWarehouseCount: 100,
workloadDuration: "30m",
initialScan: false,
rangefeed: true,
kafkaChaos: false,
targetInitialScanLatency: 30 * time.Minute,
targetSteadyLatency: time.Minute,
})
},
})
r.Add(testSpec{
Name: "cdc/sink-chaos",
MinVersion: "2.1.0",
Expand Down

0 comments on commit f0ac764

Please sign in to comment.