Skip to content

Commit

Permalink
Add missing bazel deps for azure tests and correct Go Lint errors
Browse files Browse the repository at this point in the history
  • Loading branch information
nlowe-sx committed Apr 25, 2022
1 parent f3c618c commit ef46a67
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 5 deletions.
2 changes: 2 additions & 0 deletions pkg/cloud/azure/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,12 @@ go_test(
deps = [
"//pkg/cloud",
"//pkg/cloud/cloudtestutils",
"//pkg/roachpb",
"//pkg/security",
"//pkg/settings/cluster",
"//pkg/testutils/skip",
"//pkg/util/leaktest",
"@com_github_azure_go_autorest_autorest//azure",
"@com_github_cockroachdb_errors//:errors",
"@com_github_stretchr_testify//require",
],
Expand Down
10 changes: 5 additions & 5 deletions pkg/cloud/azure/azure_storage_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,9 @@ func (a azureConfig) filePath(f string) string {

func getAzureConfig() (azureConfig, error) {
cfg := azureConfig{
account: os.Getenv("AZURE_ACCOUNT_NAME"),
key: os.Getenv("AZURE_ACCOUNT_KEY"),
bucket: os.Getenv("AZURE_CONTAINER"),
account: os.Getenv("AZURE_ACCOUNT_NAME"),
key: os.Getenv("AZURE_ACCOUNT_KEY"),
bucket: os.Getenv("AZURE_CONTAINER"),
environment: azure.PublicCloud.Name,
}
if cfg.account == "" || cfg.key == "" || cfg.bucket == "" {
Expand Down Expand Up @@ -113,9 +113,9 @@ func TestParseAzureURL(t *testing.T) {
}

func TestMakeAzureStorageURLFromEnvironment(t *testing.T) {
for _, tt := range []struct{
for _, tt := range []struct {
environment string
expected string
expected string
}{
{environment: azure.PublicCloud.Name, expected: "https://account.blob.core.windows.net/container"},
{environment: azure.USGovernmentCloud.Name, expected: "https://account.blob.core.usgovcloudapi.net/container"},
Expand Down

0 comments on commit ef46a67

Please sign in to comment.