Skip to content

Commit

Permalink
importer: fix stale comment on mysqlStrToDatum
Browse files Browse the repository at this point in the history
Release note: None
Epic: None
  • Loading branch information
otan committed Aug 7, 2023
1 parent eca28d9 commit eed5695
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions pkg/sql/importer/read_import_mysql.go
Original file line number Diff line number Diff line change
Expand Up @@ -209,9 +209,10 @@ const (
func mysqlStrToDatum(evalCtx *eval.Context, s string, desired *types.T) (tree.Datum, error) {
switch desired.Family() {
case types.BytesFamily:
// mysql emits raw byte strings that do not use the same escaping as our ParseBytes
// function expects, and the difference between ParseStringAs and
// ParseDatumStringAs is whether or not it attempts to parse bytes.
// mysql emits raw byte strings that do not use the same escaping as our
// tree.ParseDBytes function expects, and the difference between
// tree.ParseAndRequireString and mysqlStrToDatum is whether or not it
// attempts to parse bytes.
return tree.NewDBytes(tree.DBytes(s)), nil
default:
res, _, err := tree.ParseAndRequireString(desired, s, evalCtx)
Expand Down

0 comments on commit eed5695

Please sign in to comment.