-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
111313: sql/schemachanger: alter pk would temporarily disable secondary indexes r=fqazi a=fqazi Previously, when ALTER PRIMARY KEY was issued, the declarative schema changer would instantly move all existing indexes to VALIDATED. Meaning they would no longer be accessible for any read operations. This was problematic because query performance could degrade since the secondary indexes backing a table would be missing until a new secondary index was prepared. To address this, this patch adds a new rule inside the declarative schema changer that says for secondary index re-creates, we need to ensure that the new index is ready to take over before the old one is disabled. Fixes: #111076 Release note (bug fix): ALTER PRIMARY KEY would incorrectly disable secondary indexes while new secondary indexes were being backfilled when using the declarative schema changer. The second commit is focused on mixed version compatibility since we need this change to be backportable. It adds a flag into the state to prevent us from using this on states generated on older versions (i.e., they could have the secondary index disabled earlier). 111345: sql: allow injecting synthetic descriptors for new txns r=fqazi a=fqazi Previously, because synthetic descriptors were mainly used in validation/schema change code paths, where internal executors would never construct new transactions, the existing code had a bug which would not work correctly in injecting synthetic descriptors when we created new transactions. This will be needed for a future PR that will change the lease counting code to support dual formats (for session-based leases). This patch supports injecting synthetic descriptors when the internal executor makes a new transaction to address this and adds test coverage for it. EPIC: CC-24173 Release note: None 112269: storage: pebble version cleanup r=RaduBerinde a=RaduBerinde This change cleans up the code that maps cluster versions to pebble formats and allows the benchmark code to use the same logic. We also remove all deprecated version gates in storage. Epic: none Release note: None 112435: roachtest: mark ruby-pg and npgsql flaky tests r=rafiss a=rafiss These two tests flake and are not easy to reproduce. fixes #112407 fixes #112316 Release note: None 112577: sql: fix stmt bundle for local retries r=yuzefovich a=yuzefovich **sql: simplify saveFlows machinery** This commit makes `getDefaultSaveFlowsFunc` function be receiver-less to simplify the code a bit. The main idea is to use the planner to access a few fields that were previously supplied by the `PlanningCtx`. This will make it a bit easier the change in the following commit. Release note: None **sql: fix stmt bundle for local retries** This commit fixes a few things about the local `PlanningCtx` that we use when retry-as-local mechanism kicks in. In particular, previuosly we forgot to set a few observability related fields which would make it so that stmt bundles were incomplete, and this is now fixed. A few points worth calling out: - both the original distributed and retried local plans will be included in `distsql.html` and `EXPLAIN (VEC)` formats - the trace will include both too - each `planNode` in `plan.txt` will have aggregation of execution stats from both runs. This is a bit unfortunate but is not easy to fix. `distsql.html` diagrams will have the precise information for each run though - in `plan.txt` we will have `distribution: full`, and the execution time will include both runs. Fixes: #112564. Release note: None Co-authored-by: Faizan Qazi <[email protected]> Co-authored-by: Radu Berinde <[email protected]> Co-authored-by: Rafi Shamim <[email protected]> Co-authored-by: Yahor Yuzefovich <[email protected]>
- Loading branch information
Showing
181 changed files
with
3,949 additions
and
821 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.