Merge #123727

123727: server/status: complain about missing netstat less often r=dt a=dt Release note: none. Epic: none. Co-authored-by: David Taylor <[email protected]>
cockroachdb · May 7, 2024 · eaae192 · eaae192
2 parents e90d15c + ff7bb47
commit eaae192
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/pkg/server/status/runtime.go b/pkg/server/status/runtime.go
@@ -784,6 +784,8 @@ func GetCGoMemStats(ctx context.Context) *CGoMemStats {
 	}
 }
 
+var netstatEvery = log.Every(time.Minute)
+
 // SampleEnvironment queries the runtime system for various interesting metrics,
 // storing the resulting values in the set of metric gauges maintained by
 // RuntimeStatSampler. This makes runtime statistics more convenient for
@@ -852,7 +854,9 @@ func (rsr *RuntimeStatSampler) SampleEnvironment(ctx context.Context, cs *CGoMem
 	var deltaNet net.IOCountersStat
 	netCounters, err := getSummedNetStats(ctx)
 	if err != nil {
-		log.Ops.Warningf(ctx, "problem fetching net stats: %s; net stats will be empty.", err)
+		if netstatEvery.ShouldLog() {
+			log.Ops.Warningf(ctx, "problem fetching net stats: %s; net stats will be empty.", err)
+		}
 	} else {
 		deltaNet = netCounters
 		subtractNetworkCounters(&deltaNet, rsr.last.net)