Skip to content

Commit

Permalink
Merge pull request #109013 from cockroachdb/blathers/backport-release…
Browse files Browse the repository at this point in the history
…-23.1-108994
  • Loading branch information
renatolabs authored Aug 21, 2023
2 parents 26abc06 + 9a339d9 commit e9a2785
Showing 1 changed file with 10 additions and 0 deletions.
10 changes: 10 additions & 0 deletions pkg/roachprod/install/cluster_synced.go
Original file line number Diff line number Diff line change
Expand Up @@ -834,6 +834,16 @@ done
// pipe. Otherwise it can be closed under us, causing the reader to loop
// infinitely receiving a non-`io.EOF` error.
if err := sess.Wait(); err != nil {
// If we got an error waiting for the session but the context
// is already canceled, do not send an error through the
// channel; context cancelation happens at the user's request
// or when the test finishes. In either case, the monitor
// should quiesce. Reporting the error is confusing and can be
// spammy in the case of multiple monitors.
if monitorCtx.Err() != nil {
return
}

err := errors.Wrap(err, "failed to wait for session")
sendEvent(NodeMonitorInfo{Node: node, Event: MonitorError{err}})
return
Expand Down

0 comments on commit e9a2785

Please sign in to comment.