Merge #113681

113681: roachtest: fix qps parse in kvrestart test r=andrewbaptist a=kvoli The `kv/restart/nodes=12` test could fail when failing to parse the QPS metric value into a uint64. Parse as a float64, then later convert. Epic: none Release note: None Co-authored-by: Austen McClernon <[email protected]>
cockroachdb · Nov 2, 2023 · e65bc94 · e65bc94
2 parents 0045f69 + cbc01a4
commit e65bc94
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/pkg/cmd/roachtest/tests/kv.go b/pkg/cmd/roachtest/tests/kv.go
@@ -924,13 +924,13 @@ func measureQPS(
 			db := db
 			go func() {
 				defer wg.Done()
-				var v uint64
+				var v float64
 				if err := db.QueryRowContext(
 					ctx, `SELECT value FROM crdb_internal.node_metrics WHERE name = 'sql.insert.count'`,
 				).Scan(&v); err != nil {
 					t.Fatal(err)
 				}
-				atomic.AddUint64(&value, v)
+				atomic.AddUint64(&value, uint64(v))
 			}()
 		}
 		wg.Wait()