Skip to content

Commit

Permalink
roachtest: clarify when to regenerate fixtures
Browse files Browse the repository at this point in the history
Slight rewording of verMap comment to clarify that
fixture generation doesn't need to happen for older
releases.

Release justification: non-production code change
Release note: None
  • Loading branch information
celiala committed Aug 26, 2021
1 parent 7a00767 commit e617a72
Showing 1 changed file with 7 additions and 5 deletions.
12 changes: 7 additions & 5 deletions pkg/cmd/roachtest/tests/predecessor_version.go
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,13 @@ func PredecessorVersion(buildVersion version.Version) (string, error) {

buildVersionMajorMinor := fmt.Sprintf("%d.%d", buildVersion.Major(), buildVersion.Minor())

// NB: you can update the values in this map to point at newer patch
// releases. You will need to run acceptance/version-upgrade with the
// checkpoint option enabled to create the missing store directory fixture
// (see runVersionUpgrade). The same is true for adding a new key to this
// map.
// You can update the values in verMap to point at newer patch releases.
//
// NB: If a new key was added (e.g. if you're releasing a new major
// release), you'll also need to regenerate fixtures. To regenerate
// fixtures, you will need to run acceptance/version-upgrade with the
// checkpoint option enabled to create the missing store directory
// fixture (see runVersionUpgrade).
verMap := map[string]string{
"21.2": "21.1.7",
"21.1": "20.2.12",
Expand Down

0 comments on commit e617a72

Please sign in to comment.