Skip to content

Commit

Permalink
ui: change invalid lease to expired lease on problem ranges page
Browse files Browse the repository at this point in the history
When browsing the problem ranges page and invalid leases appears customers
regularly are concerned with this status as they interpret it as something
with the cluster is wrong which is often not the case. In order to imrpove this,
the invalid lease section has been changed to expired lease and there is a
description added below which explains that this status is often not a cause
for concern.

Release note (ui change): change invalid lease to expired lease on problem ranges page
  • Loading branch information
Santamaura committed Feb 18, 2022
1 parent 3317ca8 commit e0de475
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ const connectionTableColumns: ConnectionTableColumn[] = [
extract: problem => problem.no_raft_leader_range_ids.length,
},
{
title: "Invalid Lease",
title: "Expired Lease",
extract: problem => problem.no_lease_range_ids.length,
},
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ function ProblemRangeList(props: {
name: string;
problems: NodeProblems$Properties[];
extract: (p: NodeProblems$Properties) => Long[];
description?: string;
}) {
const ids = _.chain(props.problems)
.filter(problem => _.isEmpty(problem.error_message))
Expand All @@ -61,6 +62,9 @@ function ProblemRangeList(props: {
return (
<div>
<h2 className="base-heading">{props.name}</h2>
{props.description && (
<div className="problems-description">{props.description}</div>
)}
<div className="problems-list">
{_.map(ids, id => {
return (
Expand Down Expand Up @@ -179,9 +183,10 @@ export class ProblemRanges extends React.Component<ProblemRangesProps, {}> {
extract={problem => problem.no_raft_leader_range_ids}
/>
<ProblemRangeList
name="Invalid Lease"
name="Expired Lease"
problems={problems}
extract={problem => problem.no_lease_range_ids}
description="Note that having expired leases is unlikely to be a problem. They can occur after node restarts and will clear on its own in up to 24 hours."
/>
<ProblemRangeList
name="Raft Leader but not Lease Holder"
Expand Down
3 changes: 3 additions & 0 deletions pkg/ui/workspaces/db-console/styl/pages/reports.styl
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,9 @@ $reports-table
&--short
max-width 1px

.problems-description
padding-bottom 1rem

.problems-list
width 100%
background-color white
Expand Down

0 comments on commit e0de475

Please sign in to comment.