backup: set admission header on backup requests

Reelase note: none.
cockroachdb · Mar 30, 2022 · dffb0fa · dffb0fa
1 parent 4bce84e
commit dffb0fa
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/pkg/ccl/backupccl/backup_processor.go b/pkg/ccl/backupccl/backup_processor.go
@@ -409,12 +409,8 @@ func runBackupProcessor(
 					admissionHeader := roachpb.AdmissionHeader{
 						// Export requests are currently assigned NormalPri.
 						//
-						// TODO(bulkio): the priority should vary based on the urgency of
-						// these background requests. These exports should get LowPri,
-						// unless they are being retried and need to be completed in a
-						// timely manner for compliance with RPO and data retention
-						// policies. Consider deriving this from the UserPriority field.
-						Priority:                 int32(admission.NormalPri),
+						// TODO(dt): Consider linking this to/from the UserPriority field.
+						Priority:                 int32(admission.BulkNormalPri),
 						CreateTime:               timeutil.Now().UnixNano(),
 						Source:                   roachpb.AdmissionHeader_ROOT_KV,
 						NoMemoryReservedAtSource: true,

diff --git a/pkg/util/admission/work_queue.go b/pkg/util/admission/work_queue.go
@@ -152,6 +152,9 @@ const (
 	TTLLowPri WorkPriority = -100
 	// UserLowPri is low priority work from user submissions (SQL).
 	UserLowPri WorkPriority = -50
+	// BulkNormalPri is bulk priority work from bulk jobs, which could be run due
+	// to user submissions or be automatic.
+	BulkNormalPri WorkPriority = -49
 	// NormalPri is normal priority work.
 	NormalPri WorkPriority = 0
 	// UserHighPri is high priority work from user submissions (SQL).