settings: make .Override set the value origin

Prior to this patch, setting overrides in tests did not have their
value origin set properly. This patch fixes it.

Release note: None

pkg/settings/bool.go

@@ -76,6 +76,7 @@ var _ = (*BoolSetting).Default
 //
 // For testing usage only.
 func (b *BoolSetting) Override(ctx context.Context, sv *Values, v bool) {
+	sv.setValueOrigin(ctx, b.slot, OriginExplicitlySet)
 	b.set(ctx, sv, v)
 	sv.setDefaultOverride(b.slot, v)
 }

pkg/settings/duration.go

@@ -102,6 +102,7 @@ func (d *DurationSetting) Validate(v time.Duration) error {
 //
 // For testing usage only.
 func (d *DurationSetting) Override(ctx context.Context, sv *Values, v time.Duration) {
+	sv.setValueOrigin(ctx, d.slot, OriginExplicitlySet)
 	sv.setInt64(ctx, d.slot, int64(v))
 	sv.setDefaultOverride(d.slot, v)
 }

pkg/settings/float.go

@@ -80,6 +80,7 @@ var _ = (*FloatSetting).Default
 //
 // For testing usage only.
 func (f *FloatSetting) Override(ctx context.Context, sv *Values, v float64) {
+	sv.setValueOrigin(ctx, f.slot, OriginExplicitlySet)
 	if err := f.set(ctx, sv, v); err != nil {
 		panic(err)
 	}

pkg/settings/int.go

@@ -89,6 +89,7 @@ func (i *IntSetting) Validate(v int64) error {
 //
 // For testing usage only.
 func (i *IntSetting) Override(ctx context.Context, sv *Values, v int64) {
+	sv.setValueOrigin(ctx, i.slot, OriginExplicitlySet)
 	sv.setInt64(ctx, i.slot, v)
 	sv.setDefaultOverride(i.slot, v)
 }

pkg/settings/protobuf.go

@@ -107,6 +107,7 @@ func (s *ProtobufSetting) Validate(sv *Values, p protoutil.Message) error {
 
 // Override sets the setting to the given value, assuming it passes validation.
 func (s *ProtobufSetting) Override(ctx context.Context, sv *Values, p protoutil.Message) {
+	sv.setValueOrigin(ctx, s.slot, OriginExplicitlySet)
 	_ = s.set(ctx, sv, p)
 	sv.setDefaultOverride(s.slot, p)
 }

pkg/settings/string.go

@@ -81,6 +81,7 @@ func (s *StringSetting) Validate(sv *Values, v string) error {
 // Override sets the setting to the given value, assuming
 // it passes validation.
 func (s *StringSetting) Override(ctx context.Context, sv *Values, v string) {
+	sv.setValueOrigin(ctx, s.slot, OriginExplicitlySet)
 	_ = s.set(ctx, sv, v)
 	sv.setDefaultOverride(s.slot, v)
 }