Skip to content

Commit

Permalink
Merge pull request #81496 from cockroachdb/blathers/backport-release-…
Browse files Browse the repository at this point in the history
…22.1-81075

release-22.1: storage,log: reduce max sync duration default timeouts
  • Loading branch information
nicktrav authored May 19, 2022
2 parents cc1587e + 9d39e88 commit d8bc358
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion pkg/storage/pebble.go
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ import (
const maxSyncDurationFatalOnExceededDefault = true

// Default for MaxSyncDuration below.
var maxSyncDurationDefault = envutil.EnvOrDefaultDuration("COCKROACH_ENGINE_MAX_SYNC_DURATION_DEFAULT", 60*time.Second)
var maxSyncDurationDefault = envutil.EnvOrDefaultDuration("COCKROACH_ENGINE_MAX_SYNC_DURATION_DEFAULT", 20*time.Second)

// MaxSyncDuration is the threshold above which an observed engine sync duration
// triggers either a warning or a fatal error.
Expand Down
2 changes: 1 addition & 1 deletion pkg/util/log/log_flush.go
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ const syncInterval = 30
// In practice, even a fraction of that would indicate a problem. This metric's
// default should ideally match its sister metric in the storage engine, set by
// COCKROACH_ENGINE_MAX_SYNC_DURATION.
var maxSyncDuration = envutil.EnvOrDefaultDuration("COCKROACH_LOG_MAX_SYNC_DURATION", 60*time.Second)
var maxSyncDuration = envutil.EnvOrDefaultDuration("COCKROACH_LOG_MAX_SYNC_DURATION", 20*time.Second)

// syncWarnDuration is the threshold after which a slow disk warning is written
// to the log and to stderr.
Expand Down

0 comments on commit d8bc358

Please sign in to comment.