Skip to content

Commit

Permalink
acceptance: enable tracing in acceptance/version-upgrade
Browse files Browse the repository at this point in the history
If we introduced NPEs due to incompatibilities between versions, we
would want to find out. Enabling tracing globally while upgrading
clusters should help.

Release note: None
  • Loading branch information
tbg authored and angelapwen committed Feb 17, 2021
1 parent 3374d09 commit d66ba8a
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions pkg/cmd/roachtest/versionupgrade.go
Original file line number Diff line number Diff line change
@@ -135,6 +135,11 @@ func runVersionUpgrade(ctx context.Context, t *test, c *cluster, buildVersion ve
//
// See the comment on createCheckpoints for details on fixtures.
uploadAndStartFromCheckpointFixture(c.All(), predecessorVersion),
// Turn tracing on globally to give it a fighting chance at exposing
// any crash-inducing incompatibilities or horrendous memory leaks.
// (It won't catch most memory leaks since this test doesn't run for
// too long or does too much work).
enableTracingGloballyStep,
uploadAndInitSchemaChangeWorkload(),
waitForUpgradeStep(c.All()),
testFeaturesStep,

0 comments on commit d66ba8a

Please sign in to comment.