Skip to content

Commit

Permalink
roachtest/decomission: no t.Fatal on goroutine
Browse files Browse the repository at this point in the history
Fixes #51553

Release note: None
  • Loading branch information
andreimatei authored and celiala committed Jul 22, 2020
1 parent dfd3728 commit d311992
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions pkg/cmd/roachtest/decommission.go
Original file line number Diff line number Diff line change
Expand Up @@ -214,8 +214,10 @@ func runDecommission(t *test, c *cluster, nodes int, duration time.Duration) {
db := c.Conn(ctx, 1)
defer db.Close()

c.Start(ctx, t, c.Node(node), startArgs(fmt.Sprintf("-a=--join %s --attrs=node%d",
c.InternalAddr(ctx, c.Node(nodes))[0], node)))
sArgs := startArgs(fmt.Sprintf("-a=--join %s --attrs=node%d", c.InternalAddr(ctx, c.Node(nodes))[0], node))
if err := c.StartE(ctx, c.Node(node), sArgs); err != nil {
return err
}
}
// TODO(tschottdorf): run some ui sanity checks about decommissioned nodes
// having disappeared. Verify that the workloads don't dip their qps or
Expand Down

0 comments on commit d311992

Please sign in to comment.