-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
sql: set index recommendations after planning but before execution
This commit moves the call to set the index recommendations to be done right after planning was completed. Previously, it was done after the execution, but it makes more sense to do it after planning. This also allows us to remove the check on the txn still being open. This required clarifying how `instrumentationHelper.indexRecs` is used. Previously, it was used for two purposes: - for recording recommendations to be included in the `statement_statistics` system table - for showing when executing EXPLAIN statement. These two usages have somewhat different requirements, so this commit splits them out into two different slices. This also allows us to reuse the recommendations from the latter should we choose to generate the recommendations for the former (previously, this would result in redundant regeneration of the recommendations). Epic: None Release note: None
- Loading branch information
1 parent
77029b1
commit d061da4
Showing
4 changed files
with
41 additions
and
35 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters