Skip to content

Commit

Permalink
cmd/internal/issues: remove reproduction command in GH issue reporter
Browse files Browse the repository at this point in the history
Github issue reporter for failed unit tests contains an
optional `HelpCommand` field which may include a reproduction
command, supplied by `ReproductionCommandFromString`.
The latter was returning a closure instead of being invoked.

Upon further discussion, we decided to remove the call to
`ReproductionCommandFromString` altogether since the
included public wiki [1] already contains a description
on how to reproduce a unit test failure.

[1] https://cockroachlabs.atlassian.net/l/cp/HeeQsi6H

Epic: none
Release note: None
  • Loading branch information
srosenberg committed Jul 5, 2023
1 parent 40aec52 commit cf91959
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion pkg/cmd/internal/issues/formatter_unit.go
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,6 @@ var UnitTestFormatter = IssueFormatter{
// renders a reproduction command and helpful links.
func UnitTestHelpCommand(repro string) func(r *Renderer) {
return func(r *Renderer) {
ReproductionCommandFromString(repro)
r.Escaped("\n") // need this newline or link won't render
r.Escaped("See also: ")
r.A("How To Investigate a Go Test Failure (internal)", "https://cockroachlabs.atlassian.net/l/c/HgfXfJgM")
Expand Down

0 comments on commit cf91959

Please sign in to comment.