-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
changefeedccl: Emit span resolved event when end time reached
Changefeed supports a mode where the user wants to emit all events that occurred since some time in the past (`cursor`), and end the changefeed (`end_time) at the time in the near future. In this mode, the rangefeed catchup scan starting from `cursor` position could take some time -- maybe even a lot of time -- and in this case, the very first checkpoint kvfeed will observe will be after `end_time`. All of the events, including checkpoints after `end_time` are skipped, as they should. However, this meant that no changefeed checkpoint records could be produced until entire changefeed completes. This PR ensures that once the `end_time` is reached, we will emit 1 "resolved event" for that span, so that changefeed can produce span based checkpoint if needed. Fixes #108464 Release note: None
- Loading branch information
Yevgeniy Miretskiy
committed
Sep 8, 2023
1 parent
3595935
commit ca4683b
Showing
3 changed files
with
87 additions
and
28 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters