Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
kv: deflake TestInitRaftGroupOnRequest
Fixes #42808. Fixes #44146. Fixes #47020. Fixes #47551. Fixes #47231. Disable async intent resolution. This can lead to flakiness in the test because it allows for the intents written by the split transaction to be resolved at any time, including after the nodes are restarted. The intent resolution on the RHS's local range descriptor intent can both wake up the RHS range's Raft group and result in the wrong replica acquiring the lease. I was always seeing this in conjunction with the log line: ``` kv/kvserver/intentresolver/intent_resolver.go:746 failed to gc transaction record: could not GC completed transaction anchored at /Local/Range/Table/50/RangeDescriptor: node unavailable; try another peer ``` Before the fix, the test failed almost immediately when stressed on a roachprod cluster. After, I've never seen it flake: ``` 576962 runs so far, 0 failures, over 19m35s ``` I think this may have gotten more flaky after we began batching intent resolution, as this batching also introduced a delay to the async task. I'll backport this to the past few release branches.
- Loading branch information