Skip to content

Commit

Permalink
Merge #128667
Browse files Browse the repository at this point in the history
128667: workflows: use github ref name in microbench ci r=jlinder a=sambhav-jain-16

`GITHUB_REF` gives the full reference of the branch `ref/head/master`. However we only require `master` for the use case, therefore using `GITHUB_REF_NAME`

Epic: none

Release note: None

Co-authored-by: Sambhav Jain <[email protected]>
  • Loading branch information
craig[bot] and sambhav-jain-16 committed Aug 9, 2024
2 parents eb1193e + 6ceb21b commit c80a197
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion build/github/cockroach-microbench-ci.sh
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ $roachprod_microbench_dir/roachprod-microbench clean "$log_output_file_path" "$c

# Push artifact if this is a base merge and skip comparison
if $PUSH_STEP; then
gcloud storage cp "$cleaned_current_dir/$benchmark_file_name" "$storage_bucket_url/$GITHUB_REF/$GITHUB_SHA.log"
gcloud storage cp "$cleaned_current_dir/$benchmark_file_name" "$storage_bucket_url/$GITHUB_REF_NAME/$GITHUB_SHA.log"
echo "Skipping comparison since this is a push step into the target branch"
exit $success_exit_status
fi
Expand Down

0 comments on commit c80a197

Please sign in to comment.