Skip to content

Commit

Permalink
Merge pull request #62510 from yuzefovich/backport21.1-62402
Browse files Browse the repository at this point in the history
release-21.1: roachtest: not fail sqlsmith on known issue
  • Loading branch information
yuzefovich authored Mar 24, 2021
2 parents 71b5b73 + a5dd567 commit c7ca59f
Showing 1 changed file with 14 additions and 5 deletions.
19 changes: 14 additions & 5 deletions pkg/cmd/roachtest/sqlsmith.go
Original file line number Diff line number Diff line change
Expand Up @@ -191,11 +191,20 @@ func registerSQLSmith(r *testRegistry) {
}()
if err != nil {
es := err.Error()
// TODO(yuzefovich): we temporarily ignore internal errors that
// are because of #39433.
if strings.Contains(es, "internal error") && !strings.Contains(es, "internal error: invalid index") {
logStmt(stmt)
t.Fatalf("error: %s\nstmt:\n%s;", err, stmt)
if strings.Contains(es, "internal error") {
// TODO(yuzefovich): we temporarily ignore internal errors
// that are because of #39433 and #40929.
var expectedError bool
for _, exp := range []string{
"internal error: invalid index",
"could not parse \"0E-2019\" as type decimal",
} {
expectedError = expectedError || strings.Contains(es, exp)
}
if !expectedError {
logStmt(stmt)
t.Fatalf("error: %s\nstmt:\n%s;", err, stmt)
}
} else if strings.Contains(es, "communication error") {
// A communication error can be because
// a non-gateway node has crashed.
Expand Down

0 comments on commit c7ca59f

Please sign in to comment.