Revert "logcrash: add ReportTypeAssertionFailure"

This reverts commit 4ffc54c.

pkg/util/log/logcrash/crash_reporting.go

@@ -317,9 +317,6 @@ const (
 	// ReportTypeLogFatal signifies that this is an error report that
 	// was generated via a log.Fatal call.
 	ReportTypeLogFatal
-	// ReportTypeAssertionFailure signifies that an assertion was violated (see
-	// expect package).
-	ReportTypeAssertionFailure
 )
 
 // sendCrashReport posts to sentry.
@@ -379,8 +376,6 @@ func SendReport(
 		event.Tags["report_type"] = "error"
 	case ReportTypeLogFatal:
 		event.Tags["report_type"] = "log_fatal"
-	case ReportTypeAssertionFailure:
-		event.Tags["report_type"] = "assertion"
 	}
 
 	for _, f := range tagFns {
@@ -442,15 +437,13 @@ func RegisterTagFn(key string, value func(context.Context) string) {
 	tagFns = append(tagFns, tagFn{key, value})
 }
 
-func maybeSendCrashReport(ctx context.Context, err error, reportType ReportType) {
+func maybeSendCrashReport(ctx context.Context, err error) {
 	// We load the ReportingSettings from global singleton in this call path.
 	if sv := getGlobalSettings(); sv != nil {
-		sendCrashReport(ctx, sv, err, reportType)
+		sendCrashReport(ctx, sv, err, ReportTypeLogFatal)
 	}
 }
 
 func init() {
-	log.MaybeSendCrashReport = func(ctx context.Context, err error) {
-		maybeSendCrashReport(ctx, err, ReportTypeLogFatal)
-	}
+	log.MaybeSendCrashReport = maybeSendCrashReport
 }