Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
68128: sql: settings from ALTER ROLE ... SET apply on session init r=RichardJCai a=rafiss Fixes #21151 The default settings are applied when creating a new pgwire session. The information is cached alongside authentication info to reduce the latency of establishing a connection and minimize the chance of a login availability hit. Release note (sql change): Default session variable settings configured by `ALTER ROLE ... SET` are now supported. The following order of precedence is used for variable settings: 1. settings specified in the connection URL as a query parameter. 2. per-role and per-database setting configured by ALTER ROLE. 3. per-role and all-database setting configured by ALTER ROLE. 4. all-role and per-database setting configured by ALTER ROLE. 5. all-role and all-database setting configured by ALTER ROLE. RESET does not validate the setting name. SET validates both the name and the proposed default value. Note that the default settings for a role are not inherited if one role is a member of another role that has default settings. Also, the defaults _only_ apply during session initialization. Using `SET DATABASE` to change databases does not apply default settings for that database. The `public`, `admin`, and `root` roles cannot have default session variables configured. The `root` role also will never use the "all-role" default settings. This is so that `root` has fewer dependencies during session initialization and to make it less likely for `root` authentication to become unavailable during the loss of a node. Changing the default settings for a role requires the role running the ALTER command to either be an ADMIN or to have the CREATEROLE role option. Only ADMINs can edit the default settings for another admin. Futhermore, changing the default settings for `ALL` roles is _only_ allowed for ADMINs. Roles without ADMIN or CREATEROLE _cannot_ change the default settings for themselves. 68284: cli/zip: avoid quadratic behavior in SQL schema retrieval r=ajwerner a=knz Fixes #67515. Prior to this patch, the `debug zip` command would issue a `DatabaseDetails` request over the network for each database in turn, and also `TableDetails` for each table. Server-side, each of these individual requests would cause all descriptors to be loaded into memory first. The overall behavior was thus quadratic in performance, and was resulting in unacceptable delays on large clusters with thousands of descriptors. It turns out, none of this is necessary since we already collect the descriptor details via `system.descriptors` and can collect the CREATE statements trivially using the `crdb_internal.create_statements` vtable, which also has linear performance. Release note (cli change): `cockroach debug zip` no longer retrieves database and table details into separate files. The schema information is collected by means of `system.descriptors` and `crdb_internal.create_statements`. 68295: sql: add cluster setting to preserve subquery and cte ordering r=DrewKimball a=DrewKimball This patch adds an experimental cluster setting `propagate_input_ordering` that indicates whether subqueries and CTEs should propagate their orderings to their parent scopes, when the parent scope is unordered. As an example, the following two queries should produce the following result when the cluster setting is true: ``` select * from (select * from generate_series(1, 10) i order by i % 5 asc, i asc) tmp; with tmp as (select * from generate_series(1, 10) i order by i % 5 asc, i asc) select * from tmp; ---- 5 10 1 6 2 7 3 8 4 9 ``` This allows cockroach to imitate postgres behavior - while postgres does not guarantee to maintain ordering on subqueries, it does in practice. Some existing applications take advantage of this fact, and so the ability to toggle this setting can help resolve incompatibilities in some cases. Fixes #68211 Release note: None 68459: sql: refactor default privileges for all roles r=arulajmani a=RichardJCai Default privileges for all roles are refactored to be more in line with regular roles. Simplifies some code. Release note: None 68514: dev: rip recording logic out of `dev` datadriven tests r=rail a=rickystewart This feature isn't used by anyone that currently works on `dev`, and manually updating the recording files seems to be the most convenient way to work on these tests. In the future we may consider migrating to a proper mocking framework for `dev`, but for now this structure is fine. Also rename recorder -> recording for accuracy. Release note: None 68526: *: update to lib/pq v1.10.2 r=knz a=rafiss Fixes #65320 This gets us off the cockroachdb/pq fork. This revealed a bug in some of the tests and `debug` code: they were not calling rows.Close() after querying the database. The new version of lib/pq is more strict about requiring this. Additionally, logic tests were not checking `NextResultSet()`, which is a bug if the test executes multiple queries at once. Release note: none Co-authored-by: Rafi Shamim <[email protected]> Co-authored-by: Raphael 'kena' Poss <[email protected]> Co-authored-by: Drew Kimball <[email protected]> Co-authored-by: richardjcai <[email protected]> Co-authored-by: Ricky Stewart <[email protected]>
- Loading branch information
