Skip to content

Commit

Permalink
kvserver: remove rotten TODO
Browse files Browse the repository at this point in the history
This TODO was added in 2016 and the surrounding structure of the method
has entirely changed in the intervening period. It doesn't make sense
anymore as we do indeed handle heterogenous sets of replica constraints
now.

Release note: None
  • Loading branch information
aayushshah15 committed Feb 1, 2021
1 parent 6b58038 commit bea5b13
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion pkg/kv/kvserver/allocator.go
Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,6 @@ func (a *Allocator) ComputeAction(
func (a *Allocator) computeAction(
ctx context.Context, zone *zonepb.ZoneConfig, voterReplicas []roachpb.ReplicaDescriptor,
) (AllocatorAction, float64) {
// TODO(mrtracy): Handle non-homogeneous and mismatched attribute sets.
have := len(voterReplicas)
decommissioningReplicas := a.storePool.decommissioningReplicas(voterReplicas)
clusterNodes := a.storePool.ClusterNodeCount()
Expand Down

0 comments on commit bea5b13

Please sign in to comment.