Skip to content

Commit

Permalink
randgen: do not generate REGPROC and REGPROCEDURE columns
Browse files Browse the repository at this point in the history
Informs #95641

Epic: None

Release note: None
  • Loading branch information
mgartner committed Feb 1, 2023
1 parent 30cd22e commit b3666c4
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions pkg/sql/randgen/type.go
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,12 @@ func IsLegalColumnType(typ *types.T) bool {
// OIDVECTOR and INT2VECTOR are not valid column types for
// user-created tables.
return false
case oid.T_regproc, oid.T_regprocedure:
// REGPROC and REGPROCEDURE columns hit an edge case. Customers are very
// unlikely to use these types of columns, so disabling their generation
// is low risk.
// TODO(#95641): Remove this once we correctly handle this edge case.
return false
}
return colinfo.ValidateColumnDefType(typ) == nil
}
Expand Down

0 comments on commit b3666c4

Please sign in to comment.