Skip to content

Commit

Permalink
roachtest: fix DROP in ldr/kv0/workload=both/schema_change
Browse files Browse the repository at this point in the history
Without using a fully qualified name, the DROP command depends on being
connected to the correct database, which is not always guaranteed.

Release note: None
  • Loading branch information
rafiss committed Nov 26, 2024
1 parent 202c50f commit aca5afe
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions pkg/cmd/roachtest/tests/logical_data_replication.go
Original file line number Diff line number Diff line change
Expand Up @@ -293,8 +293,8 @@ func TestLDRSchemaChange(
// and right sides.
setup.left.sysSQL.Exec(t, fmt.Sprintf("CREATE INDEX idx_left ON %s.%s(v, k)", ldrWorkload.dbName, ldrWorkload.tableNames[0]))
setup.right.sysSQL.Exec(t, fmt.Sprintf("CREATE INDEX idx_right ON %s.%s(v, k)", ldrWorkload.dbName, ldrWorkload.tableNames[0]))
setup.left.sysSQL.Exec(t, "DROP INDEX idx_left")
setup.right.sysSQL.Exec(t, "DROP INDEX idx_right")
setup.left.sysSQL.Exec(t, fmt.Sprintf("DROP INDEX %s.%s@idx_left", ldrWorkload.dbName, ldrWorkload.tableNames[0]))
setup.right.sysSQL.Exec(t, fmt.Sprintf("DROP INDEX %s.%s@idx_right", ldrWorkload.dbName, ldrWorkload.tableNames[0]))

// Verify that a non-allowlisted schema change fails.
setup.left.sysSQL.ExpectErr(t,
Expand Down

0 comments on commit aca5afe

Please sign in to comment.