Skip to content

Commit

Permalink
Merge pull request #108471 from rafiss/deflake-typeorm
Browse files Browse the repository at this point in the history
release-23.1: roachtest: ignore flake in typeorm test setup
  • Loading branch information
rafiss authored Aug 10, 2023
2 parents 689d25e + 2ab862c commit a8c5c29
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion pkg/cmd/roachtest/tests/typeorm.go
Original file line number Diff line number Diff line change
Expand Up @@ -177,10 +177,13 @@ func registerTypeORM(r registry.Registry) {
t.Fatal(convErr)
}

// One test is known to flake during setup.
// Two tests are known to flake during setup.
if strings.Contains(rawResults, `"before each" hook for "should select specific columns":`) {
numFailing -= 1
}
if strings.Contains(rawResults, `"before each" hook for "should insert, load, update and remove entities with embeddeds when embeds contains special columns (e.g. CreateDateColumn, UpdateDateColumn, DeleteDateColumn, VersionColumn":`) {
numFailing -= 1
}

// Tests are allowed to flake due to transaction retry errors.
txnRetryErrCount := strings.Count(rawResults, "restart transaction")
Expand Down

0 comments on commit a8c5c29

Please sign in to comment.