Skip to content

Commit

Permalink
storage: disable replica pointer tag
Browse files Browse the repository at this point in the history
The replica pointer tag was used for debugging #11591, which has been
long since fixed.
  • Loading branch information
petermattis committed Apr 20, 2017
1 parent e722e30 commit a5bbfcf
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions pkg/storage/replica.go
Original file line number Diff line number Diff line change
Expand Up @@ -513,8 +513,9 @@ func newReplica(rangeID roachpb.RangeID, store *Store) *Replica {
r.rangeStr.store(0, &roachpb.RangeDescriptor{RangeID: rangeID})
// Add replica log tag - the value is rangeStr.String().
r.AmbientContext.AddLogTag("r", &r.rangeStr)
// Add replica pointer value.
r.AmbientContext.AddLogTagStr("@", fmt.Sprintf("%x", unsafe.Pointer(r)))
// Add replica pointer value. NB: this was historically useful for debugging
// replica GC issues, but is a distraction at the moment.
// r.AmbientContext.AddLogTagStr("@", fmt.Sprintf("%x", unsafe.Pointer(r)))

raftMuLogger := thresholdLogger(
r.AnnotateCtx(context.Background()),
Expand Down

0 comments on commit a5bbfcf

Please sign in to comment.