Skip to content

Commit

Permalink
sql: skip TestShowLastQueryStatistics under race
Browse files Browse the repository at this point in the history
This commit skips TestShowLastQueryStatistics under the `race` test flag
because the added overhead of the race detector makes latency checks in
the test fail.

Fixes #115934

Release note: None
  • Loading branch information
mgartner committed Dec 11, 2023
1 parent 8475571 commit 9bc8650
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions pkg/sql/conn_executor_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ import (
"github.com/cockroachdb/cockroach/pkg/testutils"
"github.com/cockroachdb/cockroach/pkg/testutils/pgtest"
"github.com/cockroachdb/cockroach/pkg/testutils/serverutils"
"github.com/cockroachdb/cockroach/pkg/testutils/skip"
"github.com/cockroachdb/cockroach/pkg/testutils/sqlutils"
"github.com/cockroachdb/cockroach/pkg/util/ctxgroup"
"github.com/cockroachdb/cockroach/pkg/util/duration"
Expand Down Expand Up @@ -1326,6 +1327,8 @@ func TestShowLastQueryStatistics(t *testing.T) {
defer leaktest.AfterTest(t)()
defer log.Scope(t).Close(t)

skip.UnderRace(t, "measure planning latency which is slower than usual under race")

ctx := context.Background()
params := base.TestServerArgs{}
s, sqlConn, _ := serverutils.StartServer(t, params)
Expand Down

0 comments on commit 9bc8650

Please sign in to comment.