Skip to content

Commit

Permalink
Merge #80160
Browse files Browse the repository at this point in the history
80160: kvserver: warn more aggressively about slow AddSST apply r=erikgrinaker a=tbg

AddSST application is "just" a hard-link on any kind of reasonable file system,
so it shouldn't take north of 30s ever. Anecdotally, during a recent spat of
experiments, I never saw this logging fire despite raft handling cycles taking
upward of 450s. So this is almost certainly too conservative.

Change the timeout to a 500ms cutoff, which matches the "slow raft ready"
message.

Release note: None


Co-authored-by: Tobias Grieger <[email protected]>
  • Loading branch information
craig[bot] and tbg committed Apr 25, 2022
2 parents a3c0709 + f50f191 commit 8fe42c1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/kv/kvserver/replica_proposal.go
Original file line number Diff line number Diff line change
Expand Up @@ -430,7 +430,7 @@ func (r *Replica) leasePostApplyLocked(
var addSSTPreApplyWarn = struct {
threshold time.Duration
log.EveryN
}{30 * time.Second, log.Every(5 * time.Second)}
}{500 * time.Millisecond, log.Every(time.Second)}

func addSSTablePreApply(
ctx context.Context,
Expand Down

0 comments on commit 8fe42c1

Please sign in to comment.