Skip to content

Commit

Permalink
backfill: force batch bytes limit production value if knob is set
Browse files Browse the repository at this point in the history
This commit is similar in spirit to f6b7969,
and although I'm not sure whether it matters, it seems nice to apply the
testing knob override everywhere. (I just happened to notice this while
modifying some adjacent code.)

Epic: None

Release note: None
  • Loading branch information
yuzefovich committed Oct 3, 2023
1 parent 422b70f commit 8c5cf75
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions pkg/sql/backfill/backfill.go
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,7 @@ func (cb *ColumnBackfiller) RunColumnBackfillChunk(
// read or used
if err := cb.fetcher.StartScan(
ctx, []roachpb.Span{sp}, nil, /* spanIDs */
rowinfra.GetDefaultBatchBytesLimit(false /* forceProductionValue */),
rowinfra.GetDefaultBatchBytesLimit(cb.evalCtx.TestingKnobs.ForceProductionValues),
chunkSize,
); err != nil {
log.Errorf(ctx, "scan error: %s", err)
Expand Down Expand Up @@ -864,7 +864,7 @@ func (ib *IndexBackfiller) BuildIndexEntriesChunk(
defer fetcher.Close(ctx)
if err := fetcher.StartScan(
ctx, []roachpb.Span{sp}, nil, /* spanIDs */
rowinfra.GetDefaultBatchBytesLimit(false /* forceProductionValue */),
rowinfra.GetDefaultBatchBytesLimit(ib.evalCtx.TestingKnobs.ForceProductionValues),
initBufferSize,
); err != nil {
log.Errorf(ctx, "scan error: %s", err)
Expand Down

0 comments on commit 8c5cf75

Please sign in to comment.