Skip to content

Commit

Permalink
concurrency: quieten KVNemesis failure because of validation
Browse files Browse the repository at this point in the history
We've seen KVNemesis fail regularly because of a specific validation
error. For now, quieten the assertion until the issue is fixed -- this
ensures legit bugs aren't drowned out by the noise.

Informs #115694
Informs #115598

Release note: None
  • Loading branch information
arulajmani committed Dec 12, 2023
1 parent da46efa commit 89d1451
Showing 1 changed file with 10 additions and 6 deletions.
16 changes: 10 additions & 6 deletions pkg/kv/kvserver/concurrency/lock_table.go
Original file line number Diff line number Diff line change
Expand Up @@ -3920,12 +3920,16 @@ func (kl *keyLocks) verify(st *cluster.Settings) error {
}
}
}
if !conflicts {
return errors.AssertionFailedf(
"queued locking request %d does not conflict with holder/waiting requests %s",
qlr.guard.seqNum, kl,
)
}
// TODO(arul): uncomment once 115694 is resolved. This validation has been
// regularly failing on KVNemesis -- for now, we disable it to ensure legit
// bugs aren't drowned out by the noise.
// validation
//if !conflicts {
// return errors.AssertionFailedf(
// "queued locking request %d does not conflict with holder/waiting requests %s",
// qlr.guard.seqNum, kl,
// )
//}
}

// 4. Ensure invariants around distinguished waiters hold.
Expand Down

0 comments on commit 89d1451

Please sign in to comment.