Skip to content

Commit

Permalink
ui: downsample SQL transaction metrics using MAX
Browse files Browse the repository at this point in the history
Previously, we were using the default downsampling behavior of the
timeseries query engine for "Open SQL Transactions" and "Active SQL
Statements"  on the metrics page in DB console. This led to confusion
when zooming in on transaction spikes since the spike would get larger
as the zoom got tighter.

This PR changes the aggregation function to use MAX to prevent this
confusion.

Resolves: #71827

Release note (ui change): Open SQL Transactions and Active SQL
Transactions are downsampled using MAX instead of AVG and will more
accurately reflect narrow spikes in transaction counts when looking and
downsampled data.
  • Loading branch information
dhartunian committed Feb 10, 2022
1 parent d10188f commit 86008a8
Showing 1 changed file with 6 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,11 @@ export default function(props: GraphDashboardProps) {
tooltip={`The total number of open SQL transactions ${tooltipSelection}.`}
>
<Axis label="transactions">
<Metric name="cr.node.sql.txns.open" title="Open Transactions" />
<Metric
name="cr.node.sql.txns.open"
title="Open Transactions"
downsampleMax
/>
</Axis>
</LineGraph>,

Expand All @@ -65,6 +69,7 @@ export default function(props: GraphDashboardProps) {
<Metric
name="cr.node.sql.statements.active"
title="Active Statements"
downsampleMax
/>
</Axis>
</LineGraph>,
Expand Down

0 comments on commit 86008a8

Please sign in to comment.