Skip to content

Commit

Permalink
Merge #30419
Browse files Browse the repository at this point in the history
30419: roachtest: don't disambiguate issue title by branch r=petermattis a=tschottdorf

This tends to create duplicate issues for a similar root cause. I think
it's better to collect failures from different branches in an umbrella
issue, even though it implies that we need to be more careful about
closing them (on the flip side, it incentivizes looking into all failing
branches simultaneously).

Release note: None

Co-authored-by: Tobias Schottdorf <[email protected]>
  • Loading branch information
craig[bot] and tbg committed Sep 20, 2018
2 parents 0f3ee2b + 8581e91 commit 82a5348
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions pkg/cmd/roachtest/test.go
Original file line number Diff line number Diff line change
Expand Up @@ -682,8 +682,8 @@ func (r *registry) run(
}
if err := issues.Post(
context.Background(),
fmt.Sprintf("roachtest: %s failed on %s", t.Name(), branch),
"roachtest", t.Name(), string(output), authorEmail,
fmt.Sprintf("roachtest: %s failed", t.Name()),
"roachtest", t.Name(), "The test failed on "+branch+":\n"+string(output), authorEmail,
); err != nil {
fmt.Fprintf(r.out, "failed to post issue: %s\n", err)
}
Expand Down

0 comments on commit 82a5348

Please sign in to comment.