kvserver: remove obsolete RaftEnqueuePending metric

This metric was replaced by SendQueueSize of RaftTransportMetircs. Release note: None
cockroachdb · Aug 10, 2022 · 827d310 · 827d310
1 parent 5d51ab3
commit 827d310
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 19 deletions.
diff --git a/pkg/kv/kvserver/metrics.go b/pkg/kv/kvserver/metrics.go
@@ -968,15 +968,6 @@ handling consumes writes.
 		Unit:        metric.Unit_BYTES,
 	}
 
-	metaRaftEnqueuedPending = metric.Metadata{
-		Name: "raft.enqueued.pending",
-		Help: `Number of pending outgoing messages in the Raft Transport queue.
-
-The queue is bounded in size, so instead of unbounded growth one would observe a
-ceiling value in the tens of thousands.`,
-		Measurement: "Messages",
-		Unit:        metric.Unit_COUNT,
-	}
 	metaRaftCoalescedHeartbeatsPending = metric.Metadata{
 		Name:        "raft.heartbeats.pending",
 		Help:        "Number of pending heartbeats and responses waiting to be coalesced",
@@ -1753,7 +1744,6 @@ type StoreMetrics struct {
 
 	RaftPausedFollowerCount *metric.Gauge
 
-	RaftEnqueuedPending            *metric.Gauge
 	RaftCoalescedHeartbeatsPending *metric.Gauge
 
 	// Replica queue metrics.
@@ -2264,8 +2254,6 @@ func newStoreMetrics(histogramWindow time.Duration) *StoreMetrics {
 
 		RaftPausedFollowerCount: metric.NewGauge(metaRaftFollowerPaused),
 
-		RaftEnqueuedPending: metric.NewGauge(metaRaftEnqueuedPending),
-
 		// This Gauge measures the number of heartbeats queued up just before
 		// the queue is cleared, to avoid flapping wildly.
 		RaftCoalescedHeartbeatsPending: metric.NewGauge(metaRaftCoalescedHeartbeatsPending),

diff --git a/pkg/kv/kvserver/store.go b/pkg/kv/kvserver/store.go
@@ -3287,8 +3287,6 @@ func (s *Store) updateReplicationGauges(ctx context.Context) error {
 		s.metrics.ClosedTimestampMaxBehindNanos.Update(nanos)
 	}
 
-	s.metrics.RaftEnqueuedPending.Update(s.cfg.Transport.queuedMessageCount())
-
 	return nil
 }
 

diff --git a/pkg/ts/catalog/chart_catalog.go b/pkg/ts/catalog/chart_catalog.go
@@ -1728,10 +1728,6 @@ var charts = []sectionDescription{
 				Title:   "Commands Count",
 				Metrics: []string{"raft.commandsapplied"},
 			},
-			{
-				Title:   "Enqueued",
-				Metrics: []string{"raft.enqueued.pending"},
-			},
 			{
 				Title:   "Keys/Sec Avg.",
 				Metrics: []string{"rebalancing.writespersecond"},

diff --git a/pkg/ui/workspaces/cluster-ui/src/store/nodes/nodes.fixtures.ts b/pkg/ui/workspaces/cluster-ui/src/store/nodes/nodes.fixtures.ts
@@ -806,7 +806,6 @@ export const getNodeStatus = () => {
           "queue.tsmaintenance.process.success": 3,
           "queue.tsmaintenance.processingnanos": 174301000,
           "raft.commandsapplied": 0,
-          "raft.enqueued.pending": 0,
           "raft.entrycache.accesses": 485,
           "raft.entrycache.bytes": 217172,
           "raft.entrycache.hits": 331,
-Original file line number
+Diff line change
@@ Expand Up @@
     		s.metrics.ClosedTimestampMaxBehindNanos.Update(nanos)
     	}
-    	s.metrics.RaftEnqueuedPending.Update(s.cfg.Transport.queuedMessageCount())
     	return nil
     }
@@ Expand Down @@