Skip to content

Commit

Permalink
Merge #129846
Browse files Browse the repository at this point in the history
129846: jobs: remove unnecessary stack traces from logs r=cthumuluru-crdb a=cthumuluru-crdb

Errors while executing scheduled jobs are logging lengthy stack traces in the log. Stack traces logged are not necessary for problem diagnosis and can be removed for log cleanliness.

Fixes: #119892
EPIC: CRDB-36371
Release note (general change): Avoid logging unnecessary stack traces while executing scheduled jobs.

Co-authored-by: Chandra Thumuluru <[email protected]>
  • Loading branch information
craig[bot] and cthumuluru-crdb committed Sep 5, 2024
2 parents dd0583d + 7705956 commit 7c560fc
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/jobs/job_scheduler.go
Original file line number Diff line number Diff line change
Expand Up @@ -432,7 +432,7 @@ func (s *jobScheduler) runDaemon(ctx context.Context, stopper *stop.Stopper) {
if err := whenDisabled.withCancelOnDisabled(ctx, &s.Settings.SV, func(ctx context.Context) error {
return s.executeSchedules(ctx, maxSchedules)
}); err != nil {
log.Errorf(ctx, "error executing schedules: %+v", err)
log.Errorf(ctx, "error executing schedules: %v", err)
}
}
}
Expand Down

0 comments on commit 7c560fc

Please sign in to comment.