-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
96193: roachtest/awsdms: add large data replication test r=otan a=Jeremyyang920 This commit adds a test that will create a dms task to full load 200M rows into a crdb cluster. Fixes: #95329 Release note: None 96292: rpc: Make it explicit that we only Version from Settings r=knz a=andrewbaptist Cleaning up some of the code in this package, the entire Settings object was stored in the HeartbeatService. Only the Version was required. This PR removes the unnecessary struct. Epic: none Release note: None 96313: backupccl: fix key rewriter race in generative split and scatter processor r=rhu713 a=rhu713 The generative split and scatter processor is currently causing tests to fail under race because there are many goroutines that are operating with the same splitAndScatterer, which cannot be used concurrently as the underlying key rewriter cannot be used concurrently. Modify the processor so that every worker that uses the splitAndScatterer now uses its own instance. Fixes: #95808 Release note: None 96325: ci: update bazel builder image r=rickystewart a=cockroach-teamcity Release note: None Epic: None 96346: randgen: do not generate REGPROC and REGPROCEDURE columns r=mgartner a=mgartner Informs #95641 Epic: None Release note: None 96371: cli: close listeners and all open connections on disk stall r=nicktrav a=jbowens Forwardport of #96145. ---- Disk stalls prevent a node from making progress. Any ranges for which the stalled node is leaseholder may also be prevented from making progress while the stalled node remains online but incapacitated. CockroachDB nodes detect stalls within their stores through timing all write filesystem operations. Previously, when a stall was detected, Cockroach would simply fatal the process. However, a process blocked on disk IO cannot be terminated. The process would enter the zombie state, but would be unable to be reaped. This commit adds a new step to disk stall handling, closing all open sockets. Epic: None Release note (bug fix): Fix a bug where a node with a disk stall would continue to accept new connections and preserve existing connections until the disk stall abated. Co-authored-by: Jeremy Yang <[email protected]> Co-authored-by: Andrew Baptist <[email protected]> Co-authored-by: Rui Hu <[email protected]> Co-authored-by: cockroach-teamcity <[email protected]> Co-authored-by: Marcus Gartner <[email protected]> Co-authored-by: Jackson Owens <[email protected]>
- Loading branch information
Showing
22 changed files
with
628 additions
and
143 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -368,10 +368,10 @@ def go_deps(): | |
| name = "com_github_aws_aws_sdk_go_v2", | ||
| build_file_proto_mode = "disable_global", | ||
| importpath = "github.com/aws/aws-sdk-go-v2", | ||
| sha256 = "a2dd07909b2bc4595984a5fb9c4d69afe69ef0ecc034926ec17819655120cd29", | ||
| strip_prefix = "github.com/aws/aws-sdk-go-v2@v1.16.2", | ||
| sha256 = "db9f1deea94002f8a40a665ab86b58d9c713fda9358997c75b4859668d66802a", | ||
| strip_prefix = "github.com/aws/aws-sdk-go-v2@v1.17.3", | ||
| urls = [ | ||
| "https://storage.googleapis.com/cockroach-godeps/gomod/github.com/aws/aws-sdk-go-v2/com_github_aws_aws_sdk_go_v2-v1.16.2.zip", | ||
| "https://storage.googleapis.com/cockroach-godeps/gomod/github.com/aws/aws-sdk-go-v2/com_github_aws_aws_sdk_go_v2-v1.17.3.zip", | ||
| ], | ||
| ) | ||
| go_repository( | ||
|
|
@@ -408,20 +408,20 @@ def go_deps(): | |
| name = "com_github_aws_aws_sdk_go_v2_internal_configsources", | ||
| build_file_proto_mode = "disable_global", | ||
| importpath = "github.com/aws/aws-sdk-go-v2/internal/configsources", | ||
| sha256 = "948f7cdd0e4adc5fc3743a688ebc2a685053086a27c402868f013eceea6a866e", | ||
| strip_prefix = "github.com/aws/aws-sdk-go-v2/internal/[email protected].9", | ||
| sha256 = "e7f6ed262a89b7de55994c3534734660cae21f07e138ca1ed48796048708f896", | ||
| strip_prefix = "github.com/aws/aws-sdk-go-v2/internal/[email protected].27", | ||
| urls = [ | ||
| "https://storage.googleapis.com/cockroach-godeps/gomod/github.com/aws/aws-sdk-go-v2/internal/configsources/com_github_aws_aws_sdk_go_v2_internal_configsources-v1.1.9.zip", | ||
| "https://storage.googleapis.com/cockroach-godeps/gomod/github.com/aws/aws-sdk-go-v2/internal/configsources/com_github_aws_aws_sdk_go_v2_internal_configsources-v1.1.27.zip", | ||
| ], | ||
| ) | ||
| go_repository( | ||
| name = "com_github_aws_aws_sdk_go_v2_internal_endpoints_v2", | ||
| build_file_proto_mode = "disable_global", | ||
| importpath = "github.com/aws/aws-sdk-go-v2/internal/endpoints/v2", | ||
| sha256 = "6dec0e8afc8efe4ef43c3bec089318ae48afbea583461a2e583a3864f2d2d1dc", | ||
| strip_prefix = "github.com/aws/aws-sdk-go-v2/internal/endpoints/[email protected].3", | ||
| sha256 = "4c1baeacdb316aa7d37e16045c343e53157a1a8b5209d9cbf0bcb9b0b94781bc", | ||
| strip_prefix = "github.com/aws/aws-sdk-go-v2/internal/endpoints/[email protected].21", | ||
| urls = [ | ||
| "https://storage.googleapis.com/cockroach-godeps/gomod/github.com/aws/aws-sdk-go-v2/internal/endpoints/v2/com_github_aws_aws_sdk_go_v2_internal_endpoints_v2-v2.4.3.zip", | ||
| "https://storage.googleapis.com/cockroach-godeps/gomod/github.com/aws/aws-sdk-go-v2/internal/endpoints/v2/com_github_aws_aws_sdk_go_v2_internal_endpoints_v2-v2.4.21.zip", | ||
| ], | ||
| ) | ||
| go_repository( | ||
|
|
@@ -484,6 +484,16 @@ def go_deps(): | |
| "https://storage.googleapis.com/cockroach-godeps/gomod/github.com/aws/aws-sdk-go-v2/service/rds/com_github_aws_aws_sdk_go_v2_service_rds-v1.18.4.zip", | ||
| ], | ||
| ) | ||
| go_repository( | ||
| name = "com_github_aws_aws_sdk_go_v2_service_secretsmanager", | ||
| build_file_proto_mode = "disable_global", | ||
| importpath = "github.com/aws/aws-sdk-go-v2/service/secretsmanager", | ||
| sha256 = "44dcf0add18d221042e6a709eed9beae974e5eebfe18dd37003944b7abefb271", | ||
| strip_prefix = "github.com/aws/aws-sdk-go-v2/service/[email protected]", | ||
| urls = [ | ||
| "https://storage.googleapis.com/cockroach-godeps/gomod/github.com/aws/aws-sdk-go-v2/service/secretsmanager/com_github_aws_aws_sdk_go_v2_service_secretsmanager-v1.18.2.zip", | ||
| ], | ||
| ) | ||
| go_repository( | ||
| name = "com_github_aws_aws_sdk_go_v2_service_sso", | ||
| build_file_proto_mode = "disable_global", | ||
|
|
@@ -508,10 +518,10 @@ def go_deps(): | |
| name = "com_github_aws_smithy_go", | ||
| build_file_proto_mode = "disable_global", | ||
| importpath = "github.com/aws/smithy-go", | ||
| sha256 = "62b6645d90fd3a5e55646ae1c361923491b95e7c008a6c1ff1e347232b0e55f6", | ||
| strip_prefix = "github.com/aws/smithy-go@v1.11.2", | ||
| sha256 = "864667edd8459bff1f750d65f40922263b995a06dcb85240536539e239e911e4", | ||
| strip_prefix = "github.com/aws/smithy-go@v1.13.5", | ||
| urls = [ | ||
| "https://storage.googleapis.com/cockroach-godeps/gomod/github.com/aws/smithy-go/com_github_aws_smithy_go-v1.11.2.zip", | ||
| "https://storage.googleapis.com/cockroach-godeps/gomod/github.com/aws/smithy-go/com_github_aws_smithy_go-v1.13.5.zip", | ||
| ], | ||
| ) | ||
| go_repository( | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| cockroachdb/bazel:20230103-211452 | ||
| cockroachdb/bazel:20230201-060227 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.