Skip to content

Commit

Permalink
upgrades: force production values in TestRoleMembersIDMigration1200Users
Browse files Browse the repository at this point in the history
This test was timing out sometimes due to low batch sizes.

Release note: None
  • Loading branch information
rafiss committed Aug 18, 2023
1 parent e5ef803 commit 7a701ec
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 0 deletions.
1 change: 1 addition & 0 deletions pkg/upgrade/upgrades/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,7 @@ go_test(
"//pkg/sql/schemachanger/scplan",
"//pkg/sql/sem/builtins/builtinconstants",
"//pkg/sql/sem/catid",
"//pkg/sql/sem/eval",
"//pkg/sql/sem/tree",
"//pkg/sql/types",
"//pkg/storage",
Expand Down
4 changes: 4 additions & 0 deletions pkg/upgrade/upgrades/role_members_ids_migration_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import (
"github.com/cockroachdb/cockroach/pkg/base"
"github.com/cockroachdb/cockroach/pkg/clusterversion"
"github.com/cockroachdb/cockroach/pkg/server"
"github.com/cockroachdb/cockroach/pkg/sql/sem/eval"
"github.com/cockroachdb/cockroach/pkg/testutils/skip"
"github.com/cockroachdb/cockroach/pkg/testutils/sqlutils"
"github.com/cockroachdb/cockroach/pkg/testutils/testcluster"
Expand Down Expand Up @@ -51,6 +52,9 @@ func runTestRoleMembersIDMigration(t *testing.T, numUsers int) {
tc := testcluster.StartTestCluster(t, 1 /* nodes */, base.TestClusterArgs{
ServerArgs: base.TestServerArgs{
Knobs: base.TestingKnobs{
SQLEvalContext: &eval.TestingKnobs{
ForceProductionValues: true,
},
Server: &server.TestingKnobs{
BootstrapVersionKeyOverride: clusterversion.V22_2,
DisableAutomaticVersionUpgrade: make(chan struct{}),
Expand Down

0 comments on commit 7a701ec

Please sign in to comment.