Skip to content

Commit

Permalink
kvserver: downgrade & augment "slow raft ready" message
Browse files Browse the repository at this point in the history
It doesn't rise up to the level of a `Warning`, rather, it is
informational. While I was here, I also added to the message
that seeing it could indicate that the node (or storage) is
overloaded.

Triggered by an internal question[^1] about this message.

[^1]: https://cockroachlabs.slack.com/archives/CHKQGKYEM/p1646245983917929

Release justification: low-risk logging improvement.
Release note: None
  • Loading branch information
tbg committed Mar 3, 2022
1 parent 4865605 commit 726f83d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/kv/kvserver/store_raft.go
Original file line number Diff line number Diff line change
Expand Up @@ -519,7 +519,7 @@ func (s *Store) processReady(rangeID roachpb.RangeID) {
// processing time means we'll have starved local replicas of ticks and
// remote replicas will likely start campaigning.
if elapsed >= defaultReplicaRaftMuWarnThreshold {
log.Warningf(ctx, "handle raft ready: %.1fs [applied=%d, batches=%d, state_assertions=%d]",
log.Infof(ctx, "handle raft ready: %.1fs [applied=%d, batches=%d, state_assertions=%d]; node might be overloaded",
elapsed.Seconds(), stats.entriesProcessed, stats.batchesProcessed, stats.stateAssertions)
}
}
Expand Down

0 comments on commit 726f83d

Please sign in to comment.