Merge #81700 #81705 #81759

81700: roachtest: remove privilege and grant option migration roachtest r=rafiss a=RichardJCai

Was specific to the 21.2 -> 22.2 upgrade, no longer needed
on master (22.2)

Release note: None

81705: opt: fix performance regression due to getEnv in Optimizer.Init r=cucaroach a=michae2

In f2092b6 I added a call to `randutil.NewPseudoRand` in
`Optimizer.Init`. This was more expensive than I realized, because it
checks the value of environment variable `COCKROACH_RANDOM_SEED` using
`envutil.getEnv`, which takes a global lock.

Instead, only create this rng when `testing_optimizer_random_cost_seed`
is set, and seed it directly with that value to avoid the env check
altogether.

Fixes: #81519

Release note: None

81759: colbuilder: address a minor nit in a recent fix r=yuzefovich a=yuzefovich

In 7ad29c3 we made some changes about
how argument to window functions are being cast to the same type in some
cases. After the cast we now update the column index but forgot to
update the type to the new one. However, this doesn't lead to problems
since `argTypes` is only used by the aggregate window functions, and the
casts can only be needed for non-aggregate window functions. Still, it's
better to update the types to avoid confusion.

Release note: None

Co-authored-by: richardjcai <[email protected]>
Co-authored-by: Michael Erickson <[email protected]>
Co-authored-by: Yahor Yuzefovich <[email protected]>

pkg/cmd/roachtest/tests/BUILD.bazel

@@ -97,7 +97,6 @@ go_library(
         "rapid_restart.go",
         "rebalance_load.go",
         "registry.go",
-        "remove_invalid_database_privileges.go",
         "replicagc.go",
         "reset_quorum.go",
         "restart.go",
@@ -138,7 +137,6 @@ go_library(
         "util_disk_usage.go",
         "util_if_local.go",
         "util_load_group.go",
-        "validate_grant_option.go",
         "validate_system_schema_after_version_upgrade.go",
         "version.go",
         "version_upgrade_public_schema.go",

pkg/cmd/roachtest/tests/registry.go

@@ -120,15 +120,13 @@ func RegisterTests(r registry.Registry) {
 	registerKVBench(r)
 	registerTypeORM(r)
 	registerLoadSplits(r)
-	registerValidateGrantOption(r)
 	registerVersion(r)
 	registerYCSB(r)
 	registerTPCHBench(r)
 	registerOverload(r)
 	registerMultiTenantUpgrade(r)
 	registerMultiTenantFairness(r)
 	registerVersionUpgradePublicSchema(r)
-	registerRemoveInvalidDatabasePrivileges(r)
 	registerValidateSystemSchemaAfterVersionUpgrade(r)
 	registerIndexBackfill(r)
 }

pkg/sql/colexec/colbuilder/execplan.go

@@ -1237,6 +1237,7 @@ func NewColOperator(
 					}
 					typs = append(typs, typ)
 					argIdxs[i] = castIdx
+					argTypes[i] = typ
 				}
 
 				partitionColIdx := tree.NoColumnIdx