Merge #59405

59405: roachprod: Use GP3 drives on AWS by default. r=miretskiy a=miretskiy GP3 drives are better, and 20% cheaper. Use them by default. Release Notes: None Co-authored-by: Yevgeniy Miretskiy <[email protected]>
cockroachdb · Jan 26, 2021 · 706006e · 706006e
2 parents 97d14bf + 904a2fd
commit 706006e
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/pkg/cmd/roachprod/vm/aws/aws.go b/pkg/cmd/roachprod/vm/aws/aws.go
@@ -84,6 +84,7 @@ type ebsVolume struct {
 }
 
 const ebsDefaultVolumeSizeGB = 500
+const defaultEBSVolumeType = "gp3"
 
 // Set implements flag Value interface.
 func (d *ebsDisk) Set(s string) error {
@@ -824,7 +825,7 @@ func (p *Provider) runInstance(name string, zone string, opts vm.CreateOpts) err
 	// The local NVMe devices are automatically mapped.  Otherwise, we need to map an EBS data volume.
 	if !opts.SSDOpts.UseLocalSSD {
 		if len(p.opts.EBSVolumes) == 0 && p.opts.DefaultEBSVolume.Disk.VolumeType == "" {
-			p.opts.DefaultEBSVolume.Disk.VolumeType = "gp2"
+			p.opts.DefaultEBSVolume.Disk.VolumeType = defaultEBSVolumeType
 		}
 
 		if p.opts.DefaultEBSVolume.Disk.VolumeType != "" {